Support domainname #1214
Merged
Support domainname #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@higuruchi Can I ask you to put your signature into your commits? $ git commit --amend --no-edit -s
$ git push -f origin(or upstream?) HEAD |
|
What is the status of this PR? read for review? If not, please convert to draft PR. |
Signed-off-by: higuruchi <fumiya2324@gmail.com>
higuruchi
force-pushed
the
Support_domainname
branch
from
53e4a26
to
7b7a45a
Compare
Signed-off-by: higuruchi <fumiya2324@gmail.com>
utam0k
reviewed
Sep 26, 2022
Comment on lines
206
to
215
| let res = unsafe { setdomainname(ptr, len) }; | ||
| if res == EFAULT { | ||
| bail!("Failed to set {} as domainname. domainname pointed outside of user address space.", domainname) | ||
| } | ||
| if res == EINVAL { | ||
| bail!("Failed to set {} as domainname. domainname len was negative or too large.", domainname) | ||
| } | ||
| if res == EPERM { | ||
| bail!("Failed to set {} as domainname. the caller did not have the CAP_SYS_ADMIN capability.", domainname) | ||
| } |
There was a problem hiding this comment.
How about using match instead of if statements?
There was a problem hiding this comment.
Modified to match.
And when setdomainname syscall executed errno handling is invalid so fix it.
|
Hey @higuruchi , can you fix the formatting issue that's failing the check? You will just need to run |
Signed-off-by: higuruchi <fumiya2324@gmail.com>
higuruchi
force-pushed
the
Support_domainname
branch
from
8b93d23
to
9eb878d
Compare
utam0k
approved these changes
Sep 27, 2022
|
@higuruchi Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add: #1213
Implement
Add a test for it
config.json
{ "ociVersion": "1.0.2-dev", -- snip -- "process": { -- snip -- "args": [ "domainname" ], -- snip -- }, "hostname": "youki", "domainname": "youki_domain", "annotations": {}, -- snip -- }Execution result