Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for using podman and buildah to webassembly.md #1155

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

orimanabu
Copy link
Contributor

@orimanabu orimanabu commented Aug 29, 2022

Signed-off-by: Manabu Ori manabu.ori@gmail.com

@codecov-commenter
Copy link

Codecov Report

Merging #1155 (f530c03) into main (f7fca0d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1155   +/-   ##
=======================================
  Coverage   69.41%   69.41%           
=======================================
  Files         118      118           
  Lines       12446    12446           
=======================================
  Hits         8639     8639           
  Misses       3807     3807           


Run `build.sh` with `-f wasm-wasmer` option.

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

Suggested change
```
```console

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will do.

Signed-off-by: Manabu Ori <manabu.ori@gmail.com>
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orimanabu 💯

@utam0k utam0k merged commit 3936d6c into youki-dev:main Sep 1, 2022
@orimanabu orimanabu deleted the update-wasm-doc branch September 1, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants