Added podman local system tests #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefin <stefin@pm.me>
Codecov Report
@@ Coverage Diff @@
## main #1009 +/- ##
=======================================
Coverage 69.22% 69.23%
=======================================
Files 118 118
Lines 12440 12439 -1
=======================================
Hits 8612 8612
+ Misses 3828 3827 -1 |
|
@stefins Thanks for your PR. How can I see the test result? |
Furisto
reviewed
Jun 26, 2022
| run: sudo OCI_RUNTIME=/usr/local/bin/youki ./hack/bats 2>&1 | tee build.log | ||
| - name: Adding Summary | ||
| run: | | ||
| echo "Total tests: 360 Failed tests: $(cat build.log | grep " ok " | wc -l)" >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
The expression is currently not evaluated. The test just prints
"Total tests: 360 Failed tests: $(cat build.log | grep " ok " | wc -l)" >> $GITHUB_STEP_SUMMARY
There was a problem hiding this comment.
I didn't wanted to add a RED status to the CI.
|
Maybe we should run this nightly? Running tests for 31 minutes on every pull request is quite long. |
Yeah that what I also thought. |
Furisto
reviewed
Jun 29, 2022
Furisto
approved these changes
Jun 30, 2022
|
Thank you @stefins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds podman's local system tests to the CI and produces the summary like this.
As of now 134 tests out of 360 fails to run as of using
youkias the runtime opposed tocrunRelated to #902
Thanks :)