This repository has been archived by the owner on Nov 19, 2019. It is now read-only.
Avoid babel polyfill collision when loaded multiple times by differen… #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Babel-polyfill is embedded in the published version of timeline-plus, which cause trouble when integrating with other libraries using this polyfill too.
In fact, I'm a bit surprised of the issue, because it looks that babel polyfill is added as devDependencies in your project (strange regarding documentation which specify that it should be added as a dependency https://babeljs.io/docs/en/babel-polyfill) but despite this, the polyfill is still part of the published version.
The issue with babel-polyfill (I think it depends on the version of babel), is that if you add it twice, it will raise an error instead of just a warning. A trick has been added to babel (babel/babel#6371) for muting the double import (which is probably a better approach when using polyfill in a library).