This repository has been archived by the owner on Nov 19, 2019. It is now read-only.
Fix events for labels of groups with nestedGroups #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expanding and collapsing causes the group labels to re-render. event target doesnt exist as a consequence, and event will be canceled immediately. with this patch, group labels can contain interactive elements like links (a tags)
|
Possibly better explanation: click event is not triggered because the node is removed from DOM during mouse down |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. links can now be clicked in groups containing other groups, aswell.
Closes #140
Problem was the re-rendering of group labels for expanding/collapsing groups, which causes the originating event targets (e.g. links) to be removed from the DOM. The event now won't bubble up because there's no parent anymore (to my understanding). The timeout of 1 ms breaks the expand/collapse out of the event processing, which lets the browser finish the event processing before the DOM is being modified. Expand/collapse is performed after that, as soon as the browser is idle again.
Note: group still exands/collapses when clicked on the link, and this is quite noticeable for the user. But I found no way to prevent this behavior.