feat: compatibility with symfony 6 and php 8 #12
Conversation
|
It would be amazing! Looking forward to using with Laravel 9 & PHP 8.1. Required by https://github.com/spatie/phpunit-watcher. Edit: now required by Laravel 11 & PHP 8.3. But it's overcome by using |
|
Yes :) |
|
Any update on this pull request being merged? I need it to be compatible with symfony/finder v6. |
| @@ -11,12 +16,12 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=5.6", | |||
| "symfony/finder": "^2.7|^3.0|^4.0|^5.0" | |||
| "php": ">=7.1", | |||
There was a problem hiding this comment.
If we drop php 5.6 and 7.0 support, shouldn't 5.6 and 7.0 be removed from .travis.yml too?
There was a problem hiding this comment.
I agree.
And more I think Travis-CI should be abandoned in favor of GH Actions.
There was a problem hiding this comment.
yes, i forgot to remove it. will work on it
|
How can I help to get this PR merged ? |
|
+1 |
|
Happy New Year, @yosymfony - any chance we could get this package updated? Or are you still planning to support this package? |
|
@yosymfony Still waiting your move |
|
Is there any other compatible alternative? |
|
you can install |
|
Any solution for this problem? |
|
Fork ;) |
|
For my part I use the fork of @lucassabreu: "repositories": [
{
"type": "vcs",
"url": "https://github.com/lucassabreu/resource-watcher"
}
], |
|
Wow, this is still not resolved? Cmonnnnn.... |
|
At this point, I would like to add it's time to support the v7 packages and PHP 8.3. Has this project gone stale? |
|
i am not using this anymore. |
Did you switch to an alternative? I'm running into this issue because I'm updating dependencies for spaties/phpunit-watcher which has this package as a dep. I forked your branch and updated the v7 dep for symfony/finder. |
Include yosymfony/resource-watcher directly in PHPUnit watcher so that it is easier to manage dependencies. yosymfony/resource-watcher#12
Include yosymfony/resource-watcher directly in PHPUnit watcher so that it is easier to manage dependencies. yosymfony/resource-watcher#12
Include yosymfony/resource-watcher directly in PHPUnit watcher so that it is easier to manage dependencies. yosymfony/resource-watcher#12 Minimum PHP version 8.1 Require Symfony 6 or 7
* Bump symfony package version and update resource watcher * Force new version * Revert change * Update test run with php 8.3 and re-add older phpunit versions * Remove doc blocks in favor of annotations * refactor: merge yosymfony/resource-watcher Include yosymfony/resource-watcher directly in PHPUnit watcher so that it is easier to manage dependencies. yosymfony/resource-watcher#12 Minimum PHP version 8.1 Require Symfony 6 or 7 --------- Co-authored-by: Michael Withagen <michael@lyfter.nl> Co-authored-by: Michael Withagen <michael.withagen@live.com> Co-authored-by: Pierre Clavequin <pierre.clavequin@valueapex.com>
Removed conflict with Symfony 6 and PHP 8.
I had to up the PHP version to 7.1 because of PHPUnit forcing
voidas return type onsetUpandtearDown.Also fixed PHPUnit tests failing using
symfony/filesystem:2.7(lowest).