Fixed the header rendering to match that of GFM #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flet
approved these changes
Nov 21, 2017
maxkueng
reviewed
Nov 21, 2017
| @@ -116,7 +116,7 @@ function gemojiToImages() { | |||
| } | |||
|
|
|||
| function fixHeadings() { | |||
There was a problem hiding this comment.
I think the whole fixHeadings handler can be removed. It looks like all it does did is make it possible to create headings without spaces after the #.
|
Cool! It appears that GitHub changed how it renders the headings. In issue #90 we actually added support for headings without spaces after the hashes because GitHub supported it even though it wasn't totally correct markdown. I added a comment. Maybe you can take a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed an extraneous
?from the header regex. GFM does not render headers if there's no space between the hash(es) and the text. In other words:#headeris rendered as:
#header
Whereas:
# headeris rendered as:
header
With this change
vmdcomplies with the GFM also in this regard.