Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make markdown-body class wider, fixes #105 #106

Merged
merged 1 commit into from
Oct 18, 2017
Merged

make markdown-body class wider, fixes #105 #106

merged 1 commit into from
Oct 18, 2017

Conversation

tunnckoCore
Copy link
Contributor

So to be consistent with the current github readme style width.

fixes #105

Signed-off-by: tunnckoCore <mameto2011@gmail.com>
@maxkueng maxkueng merged commit f8921e9 into yoshuawuyts:master Oct 18, 2017
@maxkueng
Copy link
Collaborator

Thanks! It's much better now. The new version is already on npm. I'll push the packaged builds later today.

@maxkueng
Copy link
Collaborator

Packaged builds are published. See the releases page.

@tunnckoCore
Copy link
Contributor Author

hey! very thanks! for some reason, didn't received the notification, but anyway! 🎉

@tunnckoCore
Copy link
Contributor Author

tunnckoCore commented Oct 23, 2017

But, btw, it should be a bit smaller, probably 965 or even 960. I noticing all this because i'm huge fan of badges and you can see how the aligns exat of that size :d

here: https://github.com/tunnckoCore/hela-config-tunnckocore

@maxkueng
Copy link
Collaborator

image
Devtools on GitHub says it's 888px with a 45px padding. Currently im vmd it's 970px with a 30px padding.

@maxkueng
Copy link
Collaborator

Okay, I've changed it in 8487ea1

@maxkueng
Copy link
Collaborator

Okay, it's in vmd 1.31.2 and your README.md looks great now.

in vmd:
image

on GitHub:
image

@tunnckoCore
Copy link
Contributor Author

Yup, seems like they are okey and the same.

Oh, yea. I always forgot that my zoom on github is 110% ;d so yea, probably 888 and 45 is the correct.

Great 🎉 Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wider body of .markdown-body
2 participants