fix: outdated and broken nix flake

[Frost-Phoenix]

This PR fixes two different problem related to the nix flake

Outdated pkgs

The flake pkgs (flake.lock file) are really outdated, they haven't been updated in over a year. This causes a build failure.

$ nix build

error: builder for '/nix/store/g033a0mll0yng54qf23wl9h3vgircbgr-superfile-1.3.0.drv' failed with exit code 1;
       last 10 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/jln4fw2z90x5qgy84x8amr0gnjawj9ls-zq6czi9bkjdwq9qa8ilvlmc6s7a6qf34-source
       > source root is zq6czi9bkjdwq9qa8ilvlmc6s7a6qf34-source
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Running phase: buildPhase
       > Building subPackage .
       > go: downloading go1.24.1 (linux/amd64)
       > go: download go1.24.1 for linux/amd64: toolchain not available
       For full logs, run:
         nix log /nix/store/g033a0mll0yng54qf23wl9h3vgircbgr-superfile-1.3.0.drv

After updating the lock file the build process can start.

Check phase fail

Now the package start to build, finishes the build phase (compiling), but fail on the check phase (when it runs the go tests)

$ nix build

error: builder for '/nix/store/0gpqxxa83n4lzznm93j95kp1f9q1vnc3-superfile-1.3.0.drv' failed with exit code 1;
       last 25 log lines:
       > time=2025-05-23T13:43:24.982Z level=ERROR msg="Error while read superfile data" error="open /homeless-shelter/.local/share/superfile/pinned.json: no such file or directory"
       > time=2025-05-23T13:43:24.983Z level=DEBUG msg="model.Update() called"
       > time=2025-05-23T13:43:24.983Z level=ERROR msg="Error while read superfile data" error="open /homeless-shelter/.local/share/superfile/pinned.json: no such file or directory"
       > time=2025-05-23T13:43:24.984Z level=DEBUG msg="model.Update() called"
       > time=2025-05-23T13:43:24.984Z level=DEBUG msg=model.handleKeyInput msg=e typestr=runes runes=[101] type=-1 paste=false alt=false
       > time=2025-05-23T13:43:24.984Z level=DEBUG msg="model.handleKeyInput. model info. " filePanelFocusIndex=0 filePanel.focusType=focus filePanel.panelMode=browserMode typingModal.open=false warnModal.open=false promptModal.open=false fileModel.renaming=false searchBar.focussed=false helpMenu.open=false firstTextInput=false focusPanel=nonePanelFocus
       > time=2025-05-23T13:43:24.985Z level=ERROR msg="Error while read superfile data" error="open /homeless-shelter/.local/share/superfile/pinned.json: no such file or directory"
       > === RUN   TestChooserFile/Open_with_file_editor_with_Invalid_chooser_file
       > time=2025-05-23T13:43:24.986Z level=ERROR msg="Error while read superfile data" error="open /homeless-shelter/.local/share/superfile/pinned.json: no such file or directory"
       > time=2025-05-23T13:43:24.988Z level=DEBUG msg="model.Update() called"
       > time=2025-05-23T13:43:24.988Z level=ERROR msg="Error while read superfile data" error="open /homeless-shelter/.local/share/superfile/pinned.json: no such file or directory"
       > time=2025-05-23T13:43:24.989Z level=DEBUG msg="model.Update() called"
       > time=2025-05-23T13:43:24.989Z level=DEBUG msg=model.handleKeyInput msg=e typestr=runes runes=[101] type=-1 paste=false alt=false
       > time=2025-05-23T13:43:24.989Z level=DEBUG msg="model.handleKeyInput. model info. " filePanelFocusIndex=0 filePanel.focusType=focus filePanel.panelMode=browserMode typingModal.open=false warnModal.open=false promptModal.open=false fileModel.renaming=false searchBar.focussed=false helpMenu.open=false firstTextInput=false focusPanel=nonePanelFocus
       > time=2025-05-23T13:43:24.989Z level=ERROR msg="Error while writing to chooser file, continuing with open via file editor" error="open /build/spf_testdir/TestChooserFile/non_existent_dir/file.txt: no such file or directory"
       > time=2025-05-23T13:43:24.989Z level=ERROR msg="Error while read superfile data" error="open /homeless-shelter/.local/share/superfile/pinned.json: no such file or directory"
       > --- PASS: TestChooserFile (0.03s)
       >     --- PASS: TestChooserFile/Open_with_default_app_with_valid_chooser_file (0.00s)
       >     --- PASS: TestChooserFile/Open_with_file_editor_with_valid_chooser_file (0.01s)
       >     --- PASS: TestChooserFile/Open_with_directory_editor_valid_chooser_file (0.01s)
       >     --- PASS: TestChooserFile/Open_with_file_editor_with_Blank_chooser_file (0.00s)
       >     --- PASS: TestChooserFile/Open_with_file_editor_with_Invalid_chooser_file (0.00s)
       > FAIL
       > FAIL github.com/yorukot/superfile/src/internal       0.338s
       > FAIL

This problem seem to be caused by the absence of certain files that are expected to be present during the test phase. This is a nix only problem as the go test runs without any issues.

A simple fix is to simply disable the check phase, as the build in itself is successful.

Result

After these two changes the build is successful and the flake can be used by nix users to get the latest version of superfile.

$ nix build
$ ./result/bin/superfile

Works as expected.

Test

To test you can run the current broken flake with nix run github:yorukot/superfile, and the flake changed by this pr with nix run "github:frost-phoenix/superfile?ref=flake-fix"

Summary by CodeRabbit

• Chores
  • Enabled tests during the build process for the superfile application.
  • Added specific native inputs to support the testing phase.

[coderabbitai]

Walkthrough

The update modifies the Nix build configuration for the superfile Go application by adding nativeCheckInputs = [ pkgs.writableTmpDirAsHomeHook ]; to the pkgs.buildGoApplication invocation in flake.nix, specifying a writable temporary directory hook for the check phase during the build.

Changes

File(s)	Change Summary
flake.nix	Adds nativeCheckInputs = [ pkgs.writableTmpDirAsHomeHook ]; to pkgs.buildGoApplication for superfile.

Poem

🐇 In fields of code where changes bloom,
A writable home clears the room.
With hooks in place, tests now run,
Superfile’s build shines like the sun.
Hopping swift through lines so bright,
The rabbit cheers, "Build done just right!" 🌿

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 309d105 and e5f99c4.

📒 Files selected for processing (1)

• flake.nix (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• flake.nix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lazysegtree]

@coderabbitai What it this check ? What are the implications of disabling it ?

[coderabbitai]

@lazysegtree The doCheck parameter controls whether the check phase runs during the Nix build process. Here's what it does:

What is the check phase?

• For Go applications built with buildGoApplication, the check phase typically runs go test to execute the project's test suite
• It's part of the standard Nix build pipeline: unpack → patch → configure → build → check → install → fixup

What doCheck = false does:

• Disables the test execution entirely during the build
• The build process skips from the build phase directly to the install phase
• Tests are not run as part of the package creation process

Implications of disabling it:

Pros:

• Faster builds - no time spent running tests
• Avoids environment-specific test failures (which is the case here)
• Still produces a working binary if the build phase succeeds

Cons:

• No test validation during packaging - potential for shipping untested code
• Less confidence in the package integrity
• May miss regressions that tests would catch

Context for this specific change:

According to the PR description, the tests were failing in the Nix build environment with errors like missing /homeless-shelter/.local/share/superfile/pinned.json, but these same tests pass when run outside of Nix. This indicates environment-specific issues rather than actual code problems.

Since the build itself succeeds and the resulting binary works correctly, disabling the check phase is a pragmatic solution to make the Nix package buildable while the underlying test environment issues could be addressed separately.

[lazysegtree]

@Frost-Phoenix I dont know much about nix. I will attempt to fix the tests. If that doesn't works, we will go with your changes to skip tests.

[coderabbitai]

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

[Frost-Phoenix]

I dont know much about nix. I will attempt to fix the tests. If that doesn't works, we will go with your changes to skip tests.

I think I found a way to make the tests work, as they managed to make it work in the upstream nixpkgs repo NixOS/nixpkgs#410196

I don't have time today, but I will look into it tomorrow.

[Frost-Phoenix]

This fixes the checkPhase, so it is no longer needed to disable it.
Could someone try it to be sure that it works ?