-
Notifications
You must be signed in to change notification settings - Fork 715
Conversation
title 是否需要必填呢?会有没有标题分享的情况吗? |
当分享链接类型为news时,不管是发送给好友还是分享到朋友圈都需要title才能正常显示,但是当分享的类型为你text时则不需要title字段,所以我个人觉得不需要必传,但如果项目中的sharemetadata能够按照分享类型做具体区分的话,那样可能会更合理一些
原始邮件
发件人:Yorkie Liunotifications@github.com
收件人:yorkie/react-native-wechatreact-native-wechat@noreply.github.com
抄送:jhaidihaidi_jin@163.com; Authorauthor@noreply.github.com
发送时间:2019年10月14日(周一) 14:31
主题:Re: [yorkie/react-native-wechat] fix interface ShareMetadata (#527)
title 是否需要必填呢?会有没有标题分享的情况吗?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
只有当分享类型为音乐、视频、网页、小程序时可添加titile描述字段,但是titile都不作为必传字段做处理 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@M1sery 你也看看这个 PR 是否有问题,没有问题你来合并吧 :p |
OK ,:) 晚一点我有时间 。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注意 interface 的写法,title?: string, => title?: string;
ok 我已经做了修改 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yorkie 测试了,这个改动在 SDK 1.7.2 版本分享好友、朋友圈没有什么问题。
好像没有 Merge PR 的权限。: ) |
https://github.com/yorkie/react-native-wechat/invitations 之前已经邀请你了,你需要在这个链接接受一下。 |
@Jhaidi Thanks : ) |
修复ShareMetaddata这个interface
不添加title时,用户调用wechat.shareToTimeline或者wechat.shareToSession进行分享时,会没有标题,导致对话列表出现[链接]null的情况