Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

fix interface ShareMetadata #527

Merged
merged 2 commits into from
Oct 16, 2019
Merged

fix interface ShareMetadata #527

merged 2 commits into from
Oct 16, 2019

Conversation

Jinx-1120
Copy link
Contributor

修复ShareMetaddata这个interface

不添加title时,用户调用wechat.shareToTimeline或者wechat.shareToSession进行分享时,会没有标题,导致对话列表出现[链接]null的情况

@yorkie
Copy link
Owner

yorkie commented Oct 14, 2019

title 是否需要必填呢?会有没有标题分享的情况吗?

@Jinx-1120
Copy link
Contributor Author

Jinx-1120 commented Oct 14, 2019 via email

@Jinx-1120
Copy link
Contributor Author

title 是否需要必填呢?会有没有标题分享的情况吗?
我又阅读了一下微信分享的开发文档

只有当分享类型为音乐、视频、网页、小程序时可添加titile描述字段,但是titile都不作为必传字段做处理

@yorkie
Copy link
Owner

yorkie commented Oct 14, 2019

title 是否需要必填呢?会有没有标题分享的情况吗?
我又阅读了一下微信分享的开发文档

只有当分享类型为音乐、视频、网页、小程序时可添加titile描述字段,但是titile都不作为必传字段做处理

好的,那这个 PR 我们先当作 Optional Property 来吧,可以在 #526 进行区分。

Copy link
Owner

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorkie
Copy link
Owner

yorkie commented Oct 14, 2019

@M1sery 你也看看这个 PR 是否有问题,没有问题你来合并吧 :p

@0xinhua
Copy link
Collaborator

0xinhua commented Oct 14, 2019

@M1sery 你也看看这个 PR 是否有问题,没有问题你来合并吧 :p

OK ,:) 晚一点我有时间 。

Copy link
Collaborator

@0xinhua 0xinhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意 interface 的写法,title?: string, => title?: string;

@Jinx-1120
Copy link
Contributor Author

注意 interface 的写法,title?: string, => title?: string;

ok 我已经做了修改

Copy link
Collaborator

@0xinhua 0xinhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yorkie 测试了,这个改动在 SDK 1.7.2 版本分享好友、朋友圈没有什么问题。

@0xinhua
Copy link
Collaborator

0xinhua commented Oct 15, 2019

@M1sery 你也看看这个 PR 是否有问题,没有问题你来合并吧 :p

好像没有 Merge PR 的权限。: )

@yorkie
Copy link
Owner

yorkie commented Oct 15, 2019

https://github.com/yorkie/react-native-wechat/invitations 之前已经邀请你了,你需要在这个链接接受一下。

@0xinhua 0xinhua merged commit 42c1d41 into yorkie:master Oct 16, 2019
@0xinhua
Copy link
Collaborator

0xinhua commented Oct 16, 2019

@Jhaidi Thanks : )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants