Skip to content

Use host (handler) logger instead of std log.#86

Open
prasad83 wants to merge 1 commit intoyookoala:mainfrom
prasad83:main
Open

Use host (handler) logger instead of std log.#86
prasad83 wants to merge 1 commit intoyookoala:mainfrom
prasad83:main

Conversation

@prasad83
Copy link
Copy Markdown

Using logger set to handler enables client to capture details.

memlog := &bytes.Buffer{}

handler := gofast.NewHandler{ ... }
handler.SetLogger(log.New(memlog, "", log.LstdFlags))
handler.ServeHTTP(...);

println( memlog )

Using logger set to handler enables client to capture details.

```
memlog := &bytes.Buffer{}

handler := gofast.NewHandler{ ... }
handler.SetLogger(log.New(memlog, "", log.LstdFlags))
handler.ServeHTTP(...);

println( memlog )
```
@yookoala
Copy link
Copy Markdown
Owner

yookoala commented Mar 31, 2024

@prasad83: Thanks for the initiative!

I'm considering to use log/slog instead of log for logging here. Seems like a much better solution. What do you think?

@prasad83
Copy link
Copy Markdown
Author

prasad83 commented Apr 1, 2024

@yookoala - handler.SetLogger expects *log.Logger are you planning to change that too?

  • log.New returns *log.Logger
  • slog.New returns *slog.Logger

@yookoala
Copy link
Copy Markdown
Owner

yookoala commented Apr 1, 2024

@prasad83 Yes. I think so.

@prasad83
Copy link
Copy Markdown
Author

prasad83 commented Apr 5, 2024

Then it would be a good choice. Thank you for the attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants