Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 10, 2020

Output: https://github.com/cclauss/flask-state/actions

Run pytest .
ImportError while loading conftest '/home/runner/work/flask-state/flask-state/tests/conftest.py'.
tests/conftest.py:4: in <module>
    from src.flask_state import DEFAULT_BIND_SQLITE
E   ModuleNotFoundError: No module named 'src'
Error: Process completed with exit code 4.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 10, 2020

  1. Added tests/__init__().py
  2. Added redis to pip installed dependencies. Should it also be added to setup.py?
  3. Added Typos found by codespell? recive ==> receive #10 for possible typos discovered by codespell
  4. pytest fails on tests/test_utils.py ....F..

@PindleskinY PindleskinY merged commit e3836eb into yoobool:master Nov 11, 2020
@PindleskinY
Copy link
Collaborator

redis is a pluggable dependency, so we do not plan to add it to setup.py. The redis ImportError will be fixed in the next version.

@PindleskinY
Copy link
Collaborator

Dear @cclauss, we sincere thanks for your those improvement code review. Have a good day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants