Conversation
1a5a93f to
6e2df1c
Compare
b56b89a to
f9944b0
Compare
|
@yonaskolb This is an Xcode 12 only feature. How do we want to go about testing this, since the fixture will fail when tested with Xcode 11? |
|
@brentleyjones: Maybe |
|
I fiddled with it a little locally. This might require a new project yml file :\ |
|
@yonaskolb FYI, we aren't actually testing this with CI because of the Spectre issue, but all of the infrastructure is in place for when we do add it. xcode: ["11"] # TODO: add 12_beta (blocked by https://github.com/kylef/Spectre/issues/41) |
yonaskolb
left a comment
There was a problem hiding this comment.
Looks good to me. I restarted the PR CI build, I'm not sure why it failed.
Also can we add onDemandInstallCapableApplication to the project spec docs
92527e2 to
527b909
Compare
Embeds App Clips into the containing app when they are a dependency.
527b909 to
ab1a6cb
Compare
|
@yonaskolb This is green now. |
|
🙌 Thanks @yonaskolb! w.r.t the Spectre issue: in Xcode 12, |
|
It looks like both Spectre and XcodeGen build fine on Xcode 12 beta 4 but GitHub Actions doesn't support it yet. They're currently targeting build |
Embeds App Clips into the containing app when they are a dependency.