mirage drive minor code improvements that spiraled a little bit #21921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moltijoe
approved these changes
Apr 23, 2024
Yogbot-13
added a commit
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
I am really tired but I saw mirage drive code and thought it looked very poor, then while fixing it I noticed a ton of other issues so I am dealing with those too
Turns SFX sounds into defines, gets rid of the new TG ones in favor of the Yog ones that are actually implemented, and uses them around the codebase.
Removes vars in args (again)
Makes megadrive properly apply damage and check armor
Why is this good for the game?
Fixes and consistency in the codebase somewhat.
Testing
I spawned in a mirage drive and attacked someone with it.
No armor with 3 tile distance
deals 15 brute
With captain armor, lowered to 14.7
5 tile distance is 21 without armor
20.4 with captain armor
Very minor but it is real now.
For comparison, on master it-
runtimes. and deals 0 damage
Changelog
🆑
fix: Mirage drive now deals damage, and properly takes armor into account (even if it's really not worth jack).
/:cl: