Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes holotool lighting #21878

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

JohnFulpWillard
Copy link
Contributor

@JohnFulpWillard JohnFulpWillard commented Apr 15, 2024

Document the changes in your pull request

set_light is a proc used for static lights, and it throws a runtime when you try to use it on movable lights (like the Holotool).
This fixes that, basically.

Why is this good for the game?

Fix

Testing

https://github.com/yogstation13/Yogstation/assets/53777086/ee7bb9d1-1ae0-4a11-b1d0-dd2e7acbcf9f
https://github.com/yogstation13/Yogstation/assets/53777086/89e90c39-e203-4288-a8c0-61b11305e3c3

Changelog

🆑
fix: Holotool now doesn't cause errors and lights should more consistently follow the player.
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Apr 15, 2024
@AMyriad
Copy link
Contributor

AMyriad commented Apr 15, 2024

damn, thought I fixed it

@JohnFulpWillard
Copy link
Contributor Author

Your PR fixed the biggest issue with it but it also caused it to runtime every time you would turn it on cause the set_light proc doesn't support using movable lights w/ them.

/// Will update the light (duh).
/// Creates or destroys it if needed, makes it update values, makes sure it's got the correct source turf...
/atom/proc/update_light()
SHOULD_NOT_SLEEP(TRUE)
if(light_system != STATIC_LIGHT)
CRASH("update_light() for [src] with following light_system value: [light_system]")

@ToasterBiome ToasterBiome merged commit 3758b4e into yogstation13:master Apr 16, 2024
13 checks passed
Yogbot-13 added a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix This fixes an issue. Please link issues in fix PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants