Replaces exploit with gamebreaking exploit in PR request template #20707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnFulpWillard
changed the title
|
Lock conversation rubs hands together |
|
is this because they secreted the AGCNR off-station should not gas station with fallout PR |
ToasterBiome
approved these changes
Oct 24, 2023
|
it would've been funnier if you used [s] for this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
The PR template says what
[s]should be used for, but just about any bug in the game can be classified as an exploit. I really don't want to have to stalk the github page to see these random PRs that fix issues that aren't breaking the game, and I think abusing it would also be bad.I also mentioned that maintainers aren't aware of PRs with [s] so they can bring it up themselves to someone available.They do actually, I just haven't noticed it.I've noticed a lot that
[s]is abused frequently here, it's really stupid. Usually it's just to avoid commenters, which I do not agree with at all- stop trying to hide stuff from people god damn.Not mentioning any PRs here because I don't want witch-hunts I just want this label to stop being used so liberally.