another attempt at fixing cult #19541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnFulpWillard
added
DO NOT MERGE
Yogbot-13
added a commit
that referenced
this pull request
Jul 9, 2023
Yogbot-13
added a commit
that referenced
this pull request
Jul 9, 2023
|
Added some extra fixes with this Players from the very beginning will see their objectives in their antag info button, they don't need to close and reopen the tab Also fixes IPCs being selected as the target |
|
Other examples Abductor Traitor (not showing Team objectives, as they arent in one) |
JohnFulpWillard
removed
DO NOT MERGE
Closed
Yogbot-13
added a commit
that referenced
this pull request
Jul 9, 2023
|
You broke the 'Convert to traitor' button |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
The error we get is that they physically cannot find the objective, which should never be the case as it seems to be given just fine, so my assumption is that it's being checked before the round even starts. This is a problem in other gamemodes but theyve been fixed because they respect parent, cult doesn't seem to.
Changelog
🆑
bugfix: Cult works now... for real.
bugfix: Cult's antag info button now starts with the objectives, rather than having to close and reopen it to see them.
bugfix: Admins can now see Cult objectives in their TP
bugfix: IPCs can no longer roll cult target
bugfix: Cult's objective text no longer has a random <b
/:cl: