-
-
Notifications
You must be signed in to change notification settings - Fork 96
Add Password Generator with Specific Special Characters #862 #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Password Generator with Specific Special Characters #862 #865
Conversation
@kapilBaser can you please add a screenshot and video for the flow |
@kapilBaser can you please check spotless issues |
@kapilBaser can we add select symbols to passwordConfig so it will be saved to preference and will be auto selected next time and the same config will be used in password generation while adding new account. |
In the current version of the app, we've added a feature where users can select specific symbols for password generation. These selections are saved in a listOfSymbols within the password configuration. Even if the activity is destroyed, the selected symbols are preserved because the PasswordConfig object is stored in userSetting. |
@kapilBaser yes, Correct |
So, Is there some more addition you want? |
My bad, PR looks good will merge after checks pass |
@kapilBaser |
Done! |
Thank you @kapilBaser for your Invaluable contribution |
It's my pleasure @yogeshpaliyal ! This is my first contribution to open source, and I'm excited to make more PRs in the future. 😊 |
Changes: