Skip to content

Conversation

kapilBaser
Copy link
Contributor

Changes:

  1. Added one more variable in PasswordConfig called listOfSymbols to ensure which symbols the user selects.
  2. I added FlowRow in the UI after the symbol checkbox.
  3. SelectSymbolForPassword (symbol: Char) was added to update the passwordConfig.listOfSymbols in GeneratePasswordViewModel.

@yogeshpaliyal
Copy link
Owner

@kapilBaser can you please add a screenshot and video for the flow

@kapilBaser
Copy link
Contributor Author

Screenshot

#862-1

Video

862.mp4

@kapilBaser kapilBaser closed this Jun 5, 2024
@kapilBaser kapilBaser reopened this Jun 5, 2024
@yogeshpaliyal
Copy link
Owner

@kapilBaser can you please check spotless issues

@yogeshpaliyal
Copy link
Owner

@kapilBaser can we add select symbols to passwordConfig so it will be saved to preference and will be auto selected next time and the same config will be used in password generation while adding new account.

@kapilBaser
Copy link
Contributor Author

In the current version of the app, we've added a feature where users can select specific symbols for password generation. These selections are saved in a listOfSymbols within the password configuration. Even if the activity is destroyed, the selected symbols are preserved because the PasswordConfig object is stored in userSetting.
I'm right?

@yogeshpaliyal
Copy link
Owner

@kapilBaser yes, Correct

@kapilBaser
Copy link
Contributor Author

So, Is there some more addition you want?

@yogeshpaliyal
Copy link
Owner

My bad, PR looks good will merge after checks pass

@yogeshpaliyal
Copy link
Owner

@kapilBaser
You can run command
./gradlew spotlessApply
./gradlew spotlessKotlinApply

@kapilBaser
Copy link
Contributor Author

Done!

@yogeshpaliyal yogeshpaliyal merged commit 993ab75 into yogeshpaliyal:master Jun 5, 2024
github-actions bot pushed a commit that referenced this pull request Jun 5, 2024
…ers #862 (#865)

* Precise choice about what special characters I need to use #862

* List Of Symbols Bug

* Changed

* Code Formatted

* SpotlessApply Checked
@yogeshpaliyal
Copy link
Owner

Thank you @kapilBaser for your Invaluable contribution ♥️

@kapilBaser
Copy link
Contributor Author

It's my pleasure @yogeshpaliyal ! This is my first contribution to open source, and I'm excited to make more PRs in the future. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants