Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] - Stored Cross-site Scripting while deleting an organization in the Organization deletion confirmation modal box! #454

Closed
TheBinitGhimire opened this issue Aug 19, 2021 · 1 comment
Labels
Security Security related issues Work in Progress Working

Comments

@TheBinitGhimire
Copy link
Contributor

TheBinitGhimire commented Aug 19, 2021

Issue Summary

In reNgine v1.0, there is Stored Cross-site Scripting while deleting an organization in the Organization deletion confirmation modal box!

Steps to Reproduce

  1. Visit your reNgine instance, and login to your account.
  2. Add some targets through the Targets page.
  3. Head over to the /target/list/organization endpoint.
  4. Click on "Add Organization" and write <img src=binit onerror=alert(document.location)> in the Organization name field.
  5. Select targets, and add the organization.
  6. Click on the cross icon under the Action column, which is used for deleting the organization.

You will notice that, while displaying "Are you sure you want to delete {Organization_Name}?", it will render our Organization Name as it is without performing any sort of sanitization, which results in our JavaScript code inside the XSS payload being executed.

This is how this vulnerability can be reproduced.

Stored Cross-site Scripting while deleting an organization!

  • I have confirmed that this issue can be reproduced as described on a latest version/pull of reNgine: yes

Technical details

  • Debian 4.19.181-1
@TheBinitGhimire TheBinitGhimire changed the title [SECURITY] - Stored Cross-site Scripting while deleting an organization! [SECURITY] - Stored Cross-site Scripting while deleting an organization in the Organization deletion confirmation modal box! Aug 20, 2021
@yogeshojha yogeshojha added Security Security related issues Work in Progress Working labels Aug 23, 2021
yogeshojha added a commit that referenced this issue Aug 23, 2021
@yogeshojha
Copy link
Owner

Thank you for reporting these security issues. Very much appreciated

Acknowledged here: https://github.com/yogeshojha/rengine/blob/master/.github/SECURITY.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security Security related issues Work in Progress Working
Projects
None yet
Development

No branches or pull requests

2 participants