Skip to content

Adds Communication Service #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Conversation

gabru-md
Copy link
Member

Adds Communication Service between the Terminal and the Tree Component.

Cheers!

@yashovardhan
Copy link
Member

code looks fine to me, just fix travis 😛

@gabru-md
Copy link
Member Author

@yashovardhanagrawal the error is something else.
Can someone debug it please in another PR ?
I cannot quite find a fix for it

@gabru-md
Copy link
Member Author

margin-top: 30px;
height: 90vh;
width: 100%
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a line at EOF.

</p>
<div id="tree">
wow
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@yashovardhan
Copy link
Member

@gabru-md give me write access for your fork, I will edit this PR a bit

@yashovardhan
Copy link
Member

or else you can DIY
first, run ng lint --fix
then there will be a few errors remaining that are because it's asking for space-indentation and you have done tab-indentation just fix them
also, replace Renderer with Renderer2

first, fix these, then we will see the coverage issue

@gabru-md
Copy link
Member Author

@ParthS007 merge ?

@yogdaan yogdaan deleted a comment from gabru-md Apr 13, 2018
@ParthS007
Copy link
Member

Merging it, 👍

@ParthS007 ParthS007 merged commit 4be7473 into yogdaan:visualize Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants