server: deduplicate RST definition normalization - #564
Merged
deribaucourt merged 1 commit intoSep 29, 2026
Merged
deribaucourt merged 1 commit into
deribaucourt merged 1 commit into
Conversation
Extract the repeated RST definition normalization into a local helper and reuse it for BitBake variables, Yocto variables, and assignment operators. This keeps the parsing behavior unchanged while removing three copies of the same conversion pipeline. AI-Generated: OpenAI ChatGPT assisted with the refactoring. Signed-off-by: Giancarlo Cicellyn Comneno <126195429+gcomneno@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the repeated RST definition normalization in
BitBakeDocScannerinto a local helper.The helper is reused by:
This is a behavior-preserving refactoring: it removes three copies of the same normalization pipeline without changing the public API or generalizing the document parsers.
Validation
npm run compilenpm run jest -- server/src/__tests__/completions.test.ts server/src/__tests__/hover.test.ts— 40/40 passednpm run lintgit diff --checkThe existing broader TODO about generalizing the parsing functions is intentionally left unchanged; this PR only extracts the duplicated normalization step.