Various minor fixes - #557
deribaucourt wants to merge 3 commits into
Conversation
This fixed me failing to run the Python integration tests on my laptop, and also fixed the Python feature when using the extension.
Without this setting, trying to trigger hover information with `K` in NeoVim produce the error "man.lua: no manual entry for X". This also enables jumping to definitions with `gd` and triggering completion with `Ctrl-Space`.
af81d80 to
2651a73
Compare
deribaucourt
changed the title
|
|
||
| showSDKConfigurationDone(chosenRecipe) | ||
| const process = runBitbakeTerminalCustomCommand(bitbakeDriver, command, `Bitbake: Devtool ide-sdk: ${chosenRecipe}`) | ||
| const result = await finishProcessExecution(process) |
There was a problem hiding this comment.
finishProcessExecution() applies the generic BITBAKE_TIMEOUT by default (300000 ms) and its default timeout callback kills the child process.
devtool ide-sdk is explicitly treated elsewhere in this file as a potentially very slow command, so this change can terminate a valid long-running SDK configuration after 5 minutes.
Could we wait for the process exit without the generic short-command timeout here, or otherwise use timeout semantics appropriate for this build-like operation?
There was a problem hiding this comment.
Good catch! ide-sdk can build the SDK, which is a slow build task.
Using BITBAKE_BUILD_TIMEOUT as the timeout here will prevent unwanted disruptions.
Previously, the notification for the successful configuration of the Devtool workspace was shown immediately when the process was started, rather than waiting for it to finish.
bfa6878 to
b8e8d20
Compare
gcomneno
left a comment
gcomneno
left a comment
There was a problem hiding this comment.
Thanks — using BITBAKE_BUILD_TIMEOUT addresses my previous concern. The updated flow now waits for ide-sdk to finish and only reports successful configuration after a successful exit. The focused test covers that behavior, and the current CI is green.
This branch has not been deployed
3 participants
When preparing a hands-on session for the Yocto Workshop associated with EOSS, I encountered a few minor issues we can easily fix.