fix: keep parse-on-save scans quiet on config errors - #526
Merged
deribaucourt merged 2 commits intoJun 11, 2026
Merged
Conversation
deribaucourt
requested changes
Jun 10, 2026
gcomneno
force-pushed
the
contrib/issue-525-parse-on-save-quiet-error
branch
from
June 11, 2026 06:08
54f66e7 to
81078d8
Compare
Contributor
Author
|
That's a better approach! Thanks! Now I simplified the patch so the on-save handler now returns early when the BitBake settings are not sane, without adding parameters to the command handlers and perform other stuff. Manual commands still keep their existing behavior. :) |
deribaucourt
requested changes
Jun 11, 2026
deribaucourt
left a comment
Member
There was a problem hiding this comment.
I tested the behavior which is perfect.
A minor remark on the code
gcomneno
force-pushed
the
contrib/issue-525-parse-on-save-quiet-error
branch
from
June 11, 2026 07:35
28490e8 to
36b012a
Compare
deribaucourt
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run compilenpm run lint -- client/src/extension.tsgit diff --checkFixes #525.