Skip to content

fix: keep parse-on-save scans quiet on config errors - #526

Merged
deribaucourt merged 2 commits into
yoctoproject:stagingfrom
gcomneno:contrib/issue-525-parse-on-save-quiet-error
Jun 11, 2026
Merged

fix: keep parse-on-save scans quiet on config errors#526
deribaucourt merged 2 commits into
yoctoproject:stagingfrom
gcomneno:contrib/issue-525-parse-on-save-quiet-error

Conversation

@gcomneno

@gcomneno gcomneno commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Skip automatic parse-on-save scans when the BitBake settings are not sane.
  • Keep manually invoked commands unchanged, so they can still focus the BitBake view on configuration errors.

Testing

  • npm run compile
  • npm run lint -- client/src/extension.ts
  • git diff --check

Fixes #525.

Comment thread client/src/extension.ts Outdated
@gcomneno gcomneno closed this Jun 11, 2026
@gcomneno
gcomneno force-pushed the contrib/issue-525-parse-on-save-quiet-error branch from 54f66e7 to 81078d8 Compare June 11, 2026 06:08
@gcomneno gcomneno reopened this Jun 11, 2026
@gcomneno

Copy link
Copy Markdown
Contributor Author

That's a better approach! Thanks! Now I simplified the patch so the on-save handler now returns early when the BitBake settings are not sane, without adding parameters to the command handlers and perform other stuff. Manual commands still keep their existing behavior. :)

@deribaucourt deribaucourt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the behavior which is perfect.
A minor remark on the code

Comment thread client/src/extension.ts
@gcomneno
gcomneno force-pushed the contrib/issue-525-parse-on-save-quiet-error branch from 28490e8 to 36b012a Compare June 11, 2026 07:35
@deribaucourt
deribaucourt merged commit 92bc8bb into yoctoproject:staging Jun 11, 2026
2 checks passed
@gcomneno
gcomneno deleted the contrib/issue-525-parse-on-save-quiet-error branch June 11, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

latest update forces the Extension page to open whenever one saves a bitbake tagged file

2 participants