Skip to content

Operations: Better error message #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Add detail to error message if is available and fill content if is not available.

Additional review information

Currently the error on failed operations does not tell anything usefull when happens. Also added ok property to response class, it was not needed at the end in this PR, but I already had it there...

Testing notes:

  1. Failed operations should tell why it crashed.

@iLLiCiTiT iLLiCiTiT self-assigned this Jan 23, 2025
@iLLiCiTiT iLLiCiTiT added the type: enhancement New feature or request label Jan 23, 2025
Copy link

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test - but code looks good to me.

@iLLiCiTiT iLLiCiTiT merged commit 34f2703 into develop Jan 23, 2025
2 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/better-operations-error branch January 23, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants