Fix addons url functions #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalisp
reviewed
Oct 9, 2024
| @@ -1323,49 +1324,44 @@ def _do_rest_request(self, function, url, **kwargs): | |||
| return new_response | |||
|
|
|||
| def raw_post(self, entrypoint, **kwargs): | |||
There was a problem hiding this comment.
Should be endpoint, not sure if is related to this PR?
kalisp
approved these changes
Oct 9, 2024
iLLiCiTiT
deleted the
bugfix/184-serverapiget_addon_settings_schema-requested-url-is-wrong
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Function
get_addon_urldoes return REST api url by default instead of base url. Added new functionget_addon_endpointto be able to choose between REST and resources endpoint if needed.Additional information
Added helper method to cleanup endpoint.
Testing notes:
You can copy paste code from this PR to AYON launcher.
get_addon_settings_schemaactually works and returns schema.Resolves #184