Skip to content

Settings variant: Don't create connection to get default settings variant #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2024
Merged

Settings variant: Don't create connection to get default settings variant #174

merged 1 commit into from
Sep 3, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Function get_default_settings_variant does not create connection if is not created yet.

Testing notes:

  1. Import and call get_default_settings_variant from ayon_api.
  2. It should return settings variant even if AYON_SERVER_URL and AYON_API_KEY are not set.

@iLLiCiTiT iLLiCiTiT requested review from kalisp and antirotor August 16, 2024 14:03
kalisp
kalisp approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this is for, but it returns production without AYON_SERVER_URL and AYON_API_KEY.

@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp Sep 3, 2024
@iLLiCiTiT iLLiCiTiT merged commit dcfb95c into develop Sep 3, 2024
@iLLiCiTiT iLLiCiTiT deleted the enhancement/better-settings-variant branch September 3, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalisp kalisp kalisp approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @kalisp