Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add staging dir to render pub #157

Closed
wants to merge 1 commit into from

Conversation

Lypsolon
Copy link

@Lypsolon Lypsolon commented Nov 4, 2024

Changelog Description

Brief description of the solution this PR is implementing. This should be only a few sentences and it will be publicly visible in the changelog. You can highlight importance of the change and add links to further information or supporting documentation

Additional review information

Detailed information of the changes made to the product or service, providing an in-depth description of the updates and enhancements. This can include technical information, code examples and anything else needed for the review of the PR.

Testing notes:

  1. start with this step
  2. follow this step

@BigRoy
Copy link
Contributor

BigRoy commented Nov 4, 2024

It would be very nice if these PRs could exclude the style changes - because now the single line change is like a bulk of changes. Seems you may have an aggressive linter at play here?

@BigRoy
Copy link
Contributor

BigRoy commented Nov 4, 2024

Also I know why this is implemented, just so that in the ayon-usd repo we can rely on it. But I'd argue that it seems we've suddenly introduced a dependency on this attribute which apparently was not needed before. As such - we're maybe misrelying on this data being present for the 'farm' scenario? I'm mostly wondering why we suddenly need this now.

Also if you expected that pinning file to live next to the USD file - then this stagingDir is not it.. it only defines where the renders will live, not where the scenes' USD file will live.

@Lypsolon
Copy link
Author

Lypsolon commented Nov 4, 2024

It would be very nice if these PRs could exclude the style changes - because now the single line change is like a bulk of changes. Seems you may have an aggressive linter at play here?

its default black and this repo has no config file.

@Lypsolon
Copy link
Author

Lypsolon commented Nov 4, 2024

Also I know why this is implemented, just so that in the ayon-usd repo we can rely on it. But I'd argue that it seems we've suddenly introduced a dependency on this attribute which apparently was not needed before. As such - we're maybe misrelying on this data being present for the 'farm' scenario? I'm mostly wondering why we suddenly need this now.

Also if you expected that pinning file to live next to the USD file - then this stagingDir is not it.. it only defines where the renders will live, not where the scenes' USD file will live.

good to know.
then i need to find out what ondra intended there because the system dose rely on some staging dir and i dont know where it should come from.

@BigRoy
Copy link
Contributor

BigRoy commented Nov 4, 2024

I think @antirotor tried to rely on the staging dir of the USD publish - not the staging dir of the rendered images.

@BigRoy
Copy link
Contributor

BigRoy commented Nov 4, 2024

its default black and this repo has no config file.

I see - be wary that I think default black has a different line length than what we use for AYON dev if I'm not mistaken.
Anyway, @antirotor how should we solve the linter discrepancy here?

@Lypsolon
Copy link
Author

Lypsolon commented Nov 4, 2024

its default black and this repo has no config file.

I see - be wary that I think default black has a different line length than what we use for AYON dev if I'm not mistaken. Anyway, @antirotor how should we solve the linter discrepancy here?

well if we dont use default then we are missing the config file.

@Lypsolon
Copy link
Author

Lypsolon commented Nov 4, 2024

I think @antirotor tried to rely on the staging dir of the USD publish - not the staging dir of the rendered images.

okay i guess that explains somme thing maybe.

@Lypsolon Lypsolon closed this Nov 4, 2024
@Lypsolon Lypsolon deleted the add_staging_dir_to_render_pub branch November 4, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants