-
Notifications
You must be signed in to change notification settings - Fork 3
Openclip loader respecting version order #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Openclip loader respecting version order #92
Conversation
| if message_args: | ||
| flame.messages.show_in_dialog(*message_args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First read https://github.com/ynput/ayon-flame/pull/92/files#r2606771730
| if message_args: | |
| flame.messages.show_in_dialog(*message_args) | |
| if not version_entity["taskId"]: | |
| flame.messages.show_in_dialog( | |
| "Import Warning", | |
| ( | |
| "Version doesn't have set task." | |
| "\nUnable to import any other versions alongside" | |
| " the current selection." | |
| "\nThis may result in unordered versions within the" | |
| " clip. Deleting the clip and reloading it will resolve" | |
| " this issue." | |
| ), | |
| "warning", | |
| ["OK"], | |
| ) |
| ) | ||
| rename_clip = clip_solver.out_clip_data is None | ||
| message_args = None | ||
| if not version_entity["taskId"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1st if this happens it means the version is not linked to a task. It doesn't mean the task was removed. Task is optional for version to be created or to exist.
2nd Why is task so important? Shouldn't that look just for all versions of the product?
all_versions = ayon_api.get_versions(
project_name,
product_ids=[version_entity["productId"]],
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may need a bit of explanation on what the relationship products have to tasks to know if this isn't required or not. Does the product id change between tasks (for example, comp and lighting renders may both be render products, but they have different product ids)? If that is not the case, then we will have to use task id as a way to maintain only using a version stream for the given task.
|
this is looking good! lets just apply suggestions where it is possible and discuss next steps later @Liametc . Thank you. |
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
lint fixes
a88e84a to
e51a612
Compare
#90
adding better openclip loading that keeps the order of versions in flame
Changelog Description
Refactored the base class for the openclip loaders to load in all available versions of a publish to help respect version ordering and allow artist to use native flame functionality to choose version to display.
Testing notes: