Skip to content

Conversation

@Liametc
Copy link
Contributor

@Liametc Liametc commented Dec 8, 2025

#90
adding better openclip loading that keeps the order of versions in flame

Changelog Description

Refactored the base class for the openclip loaders to load in all available versions of a publish to help respect version ordering and allow artist to use native flame functionality to choose version to display.

Testing notes:

  1. Create a few versions of a render
  2. bring the versions in to flame through the loader in a random order
  3. The clip version should go up in order and the last chosen version to load will be the one selected

@jakubjezek001 jakubjezek001 added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Dec 10, 2025
Comment on lines +751 to +764
if message_args:
flame.messages.show_in_dialog(*message_args)
Copy link
Member

@iLLiCiTiT iLLiCiTiT Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First read https://github.com/ynput/ayon-flame/pull/92/files#r2606771730

Suggested change
if message_args:
flame.messages.show_in_dialog(*message_args)
if not version_entity["taskId"]:
flame.messages.show_in_dialog(
"Import Warning",
(
"Version doesn't have set task."
"\nUnable to import any other versions alongside"
" the current selection."
"\nThis may result in unordered versions within the"
" clip. Deleting the clip and reloading it will resolve"
" this issue."
),
"warning",
["OK"],
)

)
rename_clip = clip_solver.out_clip_data is None
message_args = None
if not version_entity["taskId"]:
Copy link
Member

@iLLiCiTiT iLLiCiTiT Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st if this happens it means the version is not linked to a task. It doesn't mean the task was removed. Task is optional for version to be created or to exist.
2nd Why is task so important? Shouldn't that look just for all versions of the product?

            all_versions = ayon_api.get_versions(
                project_name,
                product_ids=[version_entity["productId"]],
            )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may need a bit of explanation on what the relationship products have to tasks to know if this isn't required or not. Does the product id change between tasks (for example, comp and lighting renders may both be render products, but they have different product ids)? If that is not the case, then we will have to use task id as a way to maintain only using a version stream for the given task.

@jakubjezek001
Copy link
Member

this is looking good! lets just apply suggestions where it is possible and discuss next steps later @Liametc . Thank you.

@rdelillo rdelillo removed the sponsored This is directly sponsored by a client or community member label Feb 2, 2026
Liam Hoflay and others added 5 commits February 3, 2026 09:52
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
lint fixes
@Liametc Liametc force-pushed the bugfix/90-openclip_loader_version_order branch from a88e84a to e51a612 Compare February 3, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants