Skip to content

Conversation

@antirotor
Copy link
Member

@antirotor antirotor commented Jun 10, 2025

Changelog Description

Integrate product base type into AYON on publishing.

Additional info

If instance has product base type defined, integrate it.

Closes #1296

Note

This requires ynput/ayon-python-api#255 and definitely ynput/ayon-backend#575

For more information about product base types and testing see description here #1297

@antirotor antirotor requested a review from Copilot June 10, 2025 11:13
@antirotor antirotor self-assigned this Jun 10, 2025
@antirotor antirotor added the type: enhancement Improvement of existing functionality or minor addition label Jun 10, 2025
@antirotor antirotor linked an issue Jun 10, 2025 that may be closed by this pull request
2 tasks
@antirotor antirotor added the sponsored This is directly sponsored by a client or community member label Jun 10, 2025
@ynbot ynbot added the size/XS label Jun 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates a new productBaseType field into the publishing workflow, ensuring it is passed through both the product API and template selection logic.

  • Extract and forward productBaseType in prepare_product
  • Extend get_publish_template_name to accept and filter by product_base_type

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
client/ayon_core/plugins/publish/integrate.py Added extraction of productBaseType and passed it to update calls
client/ayon_core/pipeline/publish/lib.py Extended get_publish_template_name signature and filter criteria
Comments suppressed due to low confidence (3)

client/ayon_core/plugins/publish/integrate.py:380

  • The create_product call does not include the new product_base_type parameter, so newly created products won't have this field set. Add product_base_type=product_base_type to the create_product invocation to maintain consistency with the update path.
attribs=attributes

client/ayon_core/pipeline/publish/lib.py:141

  • Filtering by product_base_type was added to the criteria, but there are no existing tests that cover templates selected based on this new filter. Consider adding unit tests for get_publish_template_name scenarios with different product_base_type values.
"product_base_types": product_base_type,

client/ayon_core/pipeline/publish/lib.py:130

  • The docstring for product_base_type still refers to it as a generic "Product type". Update this to clearly describe it as the "Product base type" to avoid confusion with product_type.
product_base_type (Optional[str]): Product type for which should

@antirotor antirotor requested a review from iLLiCiTiT November 28, 2025 10:39
@ynbot ynbot moved this to Review In Progress in PR reviewing Nov 28, 2025
antirotor and others added 6 commits December 2, 2025 15:41
when product base types are not supported by api, product base type should be the source of truth.
…pes-support-in-integrator' into enhancement/1296-product-base-types-support-in-integrator
@antirotor antirotor requested a review from iLLiCiTiT December 2, 2025 15:02
@github-project-automation github-project-automation bot moved this from Review In Progress to Merge Requested in PR reviewing Dec 3, 2025
@iLLiCiTiT iLLiCiTiT merged commit c7e9789 into develop Dec 4, 2025
2 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/1296-product-base-types-support-in-integrator branch December 4, 2025 17:03
@github-project-automation github-project-automation bot moved this from Merge Requested to Done in PR reviewing Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

🏛️Product base types: Support in integrator

4 participants