-
Notifications
You must be signed in to change notification settings - Fork 68
🏛️Product base types: Support in the integrator #1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏛️Product base types: Support in the integrator #1315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates a new productBaseType field into the publishing workflow, ensuring it is passed through both the product API and template selection logic.
- Extract and forward
productBaseTypeinprepare_product - Extend
get_publish_template_nameto accept and filter byproduct_base_type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/ayon_core/plugins/publish/integrate.py | Added extraction of productBaseType and passed it to update calls |
| client/ayon_core/pipeline/publish/lib.py | Extended get_publish_template_name signature and filter criteria |
Comments suppressed due to low confidence (3)
client/ayon_core/plugins/publish/integrate.py:380
- The
create_productcall does not include the newproduct_base_typeparameter, so newly created products won't have this field set. Addproduct_base_type=product_base_typeto thecreate_productinvocation to maintain consistency with the update path.
attribs=attributes
client/ayon_core/pipeline/publish/lib.py:141
- Filtering by
product_base_typewas added to the criteria, but there are no existing tests that cover templates selected based on this new filter. Consider adding unit tests forget_publish_template_namescenarios with differentproduct_base_typevalues.
"product_base_types": product_base_type,
client/ayon_core/pipeline/publish/lib.py:130
- The docstring for
product_base_typestill refers to it as a generic "Product type". Update this to clearly describe it as the "Product base type" to avoid confusion withproduct_type.
product_base_type (Optional[str]): Product type for which should
…roduct-base-types-support-in-integrator
when product base types are not supported by api, product base type should be the source of truth.
…pes-support-in-integrator' into enhancement/1296-product-base-types-support-in-integrator
Changelog Description
Integrate
product base typeinto AYON on publishing.Additional info
If instance has
product base typedefined, integrate it.Closes #1296
Note
This requires ynput/ayon-python-api#255 and definitely ynput/ayon-backend#575
For more information about product base types and testing see description here #1297