Add representation traits to graphql #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antirotor
added
the
type: enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds representation traits support for GraphQL by including a new JSON serialized field to simplify model definitions for pipeline usage.
- Added "traits" column retrieval in the representations resolver.
- Introduced a new nullable "traits" attribute in the representation node along with JSON serialization handling.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ayon_server/graphql/resolvers/representations.py | Adds traits field selection in the SQL query for representations. |
| ayon_server/graphql/nodes/representation.py | Introduces a new nullable traits attribute and incorporates JSON serialization for the traits field. |
Comments suppressed due to low confidence (1)
ayon_server/graphql/nodes/representation.py:111
- Consider explicitly checking for None (e.g., using record.get('traits') is not None) instead of a falsy check to ensure valid empty JSON objects are not discarded.
traits=json_dumps(record["traits"]) if record["traits"] else None,
martastain
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Adding representation traits to the node in GraphQL.
Description of changes
Traits are JSON serialized data, in GraphQL represented as string to simplify model definitions.
Technical details
This is done so pipeline code can work with traits retrieved via graphql.
Additional context
Related PRs:
ayon-core#
#466
#431