Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Hiero: thumbnail from multilayer exr #4209

Merged

Conversation

jakubjezek001
Copy link
Member

Brief description

Hiero exctract thumbnail works on mutlilayer exr

Description

Thumbnail creator needed to have specified color layer.

Testing notes:

  1. Open hiero workfile
  2. add multilayer exr at timeline
  3. Create publishable clip on the new clip
  4. publish
  5. see that all works well

@jakubjezek001 jakubjezek001 self-assigned this Dec 12, 2022
@ynbot
Copy link
Contributor

ynbot commented Dec 12, 2022

Task linked: OP-4407 Hiero | Extract Thumbnail error

@jakubjezek001 jakubjezek001 added host: Hiero type: bug Something isn't working labels Dec 12, 2022
Copy link
Collaborator

@jrsndl jrsndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for multilayer EXRs that have a colour channel [1].
Unfortunately it fails on EXRs with tech passes only, that often do not have any colour [2].

image

@jakubjezek001
Copy link
Member Author

This works for multilayer EXRs that have a colour channel [1].
Unfortunately it fails on EXRs with tech passes only, that often do not have any colour [2].

image

I wonder if this is not edge case nobody will hit in production. Yes we are having only colour layer set for thumbnail. I can do exception to soft fail in case no colour pass is present, because it is quite difficult to define which of technical passes should be used for thumnails.

@jrsndl
Copy link
Collaborator

jrsndl commented Dec 20, 2022

exception to soft fail in case no colour pass is present, because it is quite difficult to define which of technical passes should be used for thumnails.

Either that, or if you can pull the list of layers from Hiero, just take a first one if colour is not present?

@jakubjezek001
Copy link
Member Author

exception to soft fail in case no colour pass is present, because it is quite difficult to define which of technical passes should be used for thumnails.

Either that, or if you can pull the list of layers from Hiero, just take a first one if colour is not present?

I would wrap this known limitation and not to waste time on it, since this is quite unlike edge case.

@jakubjezek001 jakubjezek001 requested a review from jrsndl December 22, 2022 13:48
@jakubjezek001
Copy link
Member Author

@jrsndl there is missing api support on Hiero to get list of available layers from a clip. I had tested the workaround with nuke.layers(node) but this works only in Nuke environment.

Copy link
Collaborator

@jrsndl jrsndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for multilayer EXRs that have colour (rgb/rgba) layer

@jakubjezek001 jakubjezek001 merged commit de9f6d1 into develop Jan 4, 2023
@jakubjezek001 jakubjezek001 deleted the bugfix/OP-4407_Hiero--Extract-Thumbnail-error branch January 4, 2023 12:57
@github-actions github-actions bot added this to the next-patch milestone Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Hiero type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants