Skip to content

Commit

Permalink
chore: update electron notarize (Jigsaw-Code#1128)
Browse files Browse the repository at this point in the history
* ...

* apple password, apple team id
  • Loading branch information
daniellacosse authored Jul 28, 2022
1 parent 84f978d commit b9a0f30
Show file tree
Hide file tree
Showing 4 changed files with 87 additions and 9 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ node_modules/
.vscode/
.idea/
third_party/shellcheck/download/
macos-signing-certificate.p12
86 changes: 79 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion src/server_manager/electron_app/release/notarize.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,14 @@ exports.default = async function (context) {
const appName = context.packager.appInfo.productFilename;
console.log(`Notarizing ${appName}. This may take a few minutes.`);
await notarize({
appBundleId: 'com.electron.outline-manager',
tool: 'notarytool',
appPath: `${appOutDir}/${appName}.app`,
appleId: process.env.APPLE_ID,

// You'll have to generate a one-time password as the
// notary tool does not support 2FA:
// https://support.apple.com/en-us/HT204397
appleIdPassword: process.env.APPLE_PASSWORD,
teamId: process.env.APPLE_TEAM_ID,
});
};
2 changes: 1 addition & 1 deletion src/server_manager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"electron": "18.1.0",
"electron-builder": "~23.0.3",
"electron-icon-maker": "^0.0.4",
"electron-notarize": "^0.2.1",
"electron-notarize": "^1.2.1",
"electron-to-chromium": "^1.4.122",
"gulp": "^4.0.0",
"gulp-posthtml": "^3.0.4",
Expand Down

0 comments on commit b9a0f30

Please sign in to comment.