fix(manager): use typeof function instead of directly comparison (Jig…

…saw-Code#1481)
ym9523 · Feb 2, 2024 · 882573e · 882573e
1 parent 3273e7c
commit 882573e
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/server_manager/web_app/ui_components/outline-server-settings.ts b/src/server_manager/web_app/ui_components/outline-server-settings.ts
@@ -456,15 +456,15 @@ Polymer({
   },
 
   _defaultDataLimitEnabledChanged(e: CustomEvent) {
-    const wasDataLimitEnabled = this.isDefaultDataLimitEnabled;
-    const isDataLimitEnabled = e.detail.value === 'enabled';
-    if (isDataLimitEnabled === undefined || wasDataLimitEnabled === undefined) {
+    if (e.detail?.value === undefined) {
       return;
-    } else if (isDataLimitEnabled === wasDataLimitEnabled) {
+    }
+    const enableDataLimit = e.detail.value === 'enabled';
+    if (this.isDefaultDataLimitEnabled === enableDataLimit) {
       return;
     }
-    this.isDefaultDataLimitEnabled = isDataLimitEnabled;
-    if (isDataLimitEnabled) {
+    this.isDefaultDataLimitEnabled = enableDataLimit;
+    if (enableDataLimit) {
       this._requestSetDefaultDataLimit();
     } else {
       this.fire('RemoveDefaultDataLimitRequested');