Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with PyQt5 and PyQt6 #2

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ludovicmantovani
Copy link
Contributor

  • Added dynamic imports for PyQt5 and PyQt6.
  • Managed Qt constants across versions.
  • Tested and confirmed functionality on both versions.

@ludovicmantovani
Copy link
Contributor Author

This widget is very interesting, but it wasn’t compatible with my version of PyQt. Therefore, I’m proposing these changes to ensure compatibility with both PyQt5 and PyQt6.
This is also a great opportunity for me to contribute to an open-source project.
Please let me know if any additional changes are needed!

@yjg30737
Copy link
Owner

You have a great coding skill.
We can use both pyqt by try-except trick instead of using qtpy.
Thanks for inspiring me.

@yjg30737 yjg30737 merged commit da9bf77 into yjg30737:main Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants