Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: include Eigen targets #128

Merged
merged 1 commit into from
Oct 19, 2021
Merged

CMake: include Eigen targets #128

merged 1 commit into from
Oct 19, 2021

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Sep 15, 2021

The targets file links to the Eigen3::Eigen target so we must include it here instead of the client side,
else we get a cmake error about a missing Eigen3::Eigen target

The targets file links to the Eigen3::Eigen target so we must include here instead of the client side
@codecov-commenter
Copy link

Codecov Report

Merging #128 (819cc48) into master (904bbbe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #128   +/-   ##
======================================
  Coverage    92.1%   92.1%           
======================================
  Files          45      45           
  Lines        2140    2140           
======================================
  Hits         1971    1971           
  Misses        169     169           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904bbbe...819cc48. Read the comment docs.

@jschueller
Copy link
Contributor Author

hello @yixuan could you have a look at this one ?

@yixuan yixuan merged commit 1690f6a into yixuan:master Oct 19, 2021
@yixuan
Copy link
Owner

yixuan commented Oct 19, 2021

Sorry for the delay. This looks good, already merged.

@jschueller jschueller deleted the patch-2 branch October 19, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants