Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Davidson Space Size #125

Merged
merged 4 commits into from
Aug 14, 2021
Merged

Davidson Space Size #125

merged 4 commits into from
Aug 14, 2021

Conversation

shivupa
Copy link
Contributor

@shivupa shivupa commented Jun 24, 2021

This allows the user to set initial and maximum search spaces

@shivupa
Copy link
Contributor Author

shivupa commented Jun 24, 2021

Sorry I will fix this

@shivupa shivupa force-pushed the Davidsonspacesize branch from 1a794f2 to 5c8d57a Compare July 1, 2021 19:31
@codecov-commenter
Copy link

Codecov Report

Merging #125 (5c8d57a) into master (148d019) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #125   +/-   ##
======================================
  Coverage    92.0%   92.1%           
======================================
  Files          45      45           
  Lines        2137    2140    +3     
======================================
+ Hits         1968    1971    +3     
  Misses        169     169           
Impacted Files Coverage Δ
include/Spectra/DavidsonSymEigsSolver.h 100.0% <100.0%> (ø)
include/Spectra/JDSymEigsBase.h 89.1% <100.0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148d019...5c8d57a. Read the comment docs.

@yixuan
Copy link
Owner

yixuan commented Jul 2, 2021

Looks great! I'll take a look and maybe @JensWehner also has some comments?

@yixuan
Copy link
Owner

yixuan commented Aug 14, 2021

I think it is good to merge. Thanks!

@yixuan yixuan merged commit 904bbbe into yixuan:master Aug 14, 2021
@JensWehner
Copy link
Contributor

Sorry, just saw it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants