if space dropped before task finish report, the job status should be …

…marked finished (vesoft-inc#81) Co-authored-by: liuyu <52276794+liuyu85cn@users.noreply.github.com>
yixinglu · Sep 15, 2021 · 218cf89 · 218cf89
1 parent 788caae
commit 218cf89
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/meta/processors/job/JobManager.cpp b/src/meta/processors/job/JobManager.cpp
@@ -247,15 +247,15 @@ nebula::cpp2::ErrorCode JobManager::saveTaskStatus(TaskDescription& td,
   }
 
   if (!optJobDesc.getParas().empty()) {
+    GraphSpaceID spaceId = -1;
     auto spaceName = optJobDesc.getParas().back();
     auto spaceIdRet = getSpaceId(spaceName);
     if (!nebula::ok(spaceIdRet)) {
       auto retCode = nebula::error(spaceIdRet);
       LOG(WARNING) << "Get spaceName " << spaceName
                    << " failed, error: " << apache::thrift::util::enumNameSafe(retCode);
-      return retCode;
     } else {
-      auto spaceId = nebula::value(spaceIdRet);
+      spaceId = nebula::value(spaceIdRet);
       jobExec->setSpaceId(spaceId);
     }
   }