Skip to content

Issue 33: Usage With Elements Within Shadow Dom#46

Closed
israelfloresdga wants to merge 3 commits intoyiminghe:masterfrom
israelfloresdga:issue-33
Closed

Issue 33: Usage With Elements Within Shadow Dom#46
israelfloresdga wants to merge 3 commits intoyiminghe:masterfrom
israelfloresdga:issue-33

Conversation

@israelfloresdga
Copy link

Fix issue #33

@coveralls
Copy link

coveralls commented Jun 27, 2019

Coverage Status

Coverage remained the same at 68.75% when pulling 0176b74 on israelfloresdga:issue-33 into 05db525 on yiminghe:master.

@israelfloresdga
Copy link
Author

israelfloresdga commented Jun 27, 2019

Mmm, I'm new, how I update the pull request?

/home/travis/build/yiminghe/dom-align/src/utils.js
  142:1  error  Line 142 exceeds the maximum line length of 100  max-len

🤦‍♂

@Defunctionalize
Copy link

Hey, just chiming in here to say this change would be extremely valuable to me!
@yiminghe fingers crossed to get this in!

@yiminghe yiminghe requested a review from zombieJ July 1, 2019 06:36
@yiminghe
Copy link
Owner

yiminghe commented Jul 1, 2019

need a testcase

yiminghe added a commit that referenced this pull request Jul 1, 2019
@yiminghe yiminghe closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants