Issue vesoft-inc#1203 fixed the possible crash. (vesoft-inc#1204)

The crash is caused by the use of two meaningless DCHECK in debug mode.
yim055 · Nov 5, 2019 · 7cdcc70 · 7cdcc70
1 parent 75326df
commit 7cdcc70
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/graph/GoExecutor.cpp b/src/graph/GoExecutor.cpp
@@ -983,8 +983,7 @@ OptVariantType GoExecutor::VertexHolder::getDefaultProp(TagID tid, const std::st
         }
     }
 
-    DCHECK(false);
-    return Status::Error("Unknown tid");
+    return Status::Error("Unknown Vertex");
 }
 
 SupportedType GoExecutor::VertexHolder::getDefaultPropType(TagID tid,
@@ -996,7 +995,6 @@ SupportedType GoExecutor::VertexHolder::getDefaultPropType(TagID tid,
         }
     }
 
-    DCHECK(false);
     return nebula::cpp2::SupportedType::UNKNOWN;
 }