Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#8298) Restart sequence for Postgresql when loading fixtures #20227

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s1lver
Copy link
Member

@s1lver s1lver commented Jul 11, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #8298

The solution in issue #17253 does notconsider the condition when the sequence does not start at 1.
For example, the sequence might look like this:

create sequence test_id_seq
    minvalue 3
    maxvalue 32767;

In order not to break potential BC, we make a fix only in ActiveFixture for the pgsql driver.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.57%. Comparing base (5f5ef64) to head (f046a82).

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20227      +/-   ##
============================================
- Coverage     64.98%   63.57%   -1.42%     
- Complexity    11391    11392       +1     
============================================
  Files           430      430              
  Lines         36919    36921       +2     
============================================
- Hits          23993    23471     -522     
- Misses        12926    13450     +524     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s1lver s1lver marked this pull request as draft July 11, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant