Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rerturn number of rows affected by the executeResetSequence #20056

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

borgou
Copy link

@borgou borgou commented Oct 27, 2023

Add number of rows affected by the executeResetSequence.

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️
Fixed issues Rerturn number of rows affected by the executeResetSequence

Add number of rows affected by the executeResetSequence.
@what-the-diff
Copy link

what-the-diff bot commented Oct 27, 2023

PR Summary

  • Update to executeResetSequence Method in QueryBuilder.php
    • This update brings a key modification to the executeResetSequence method. Specifically, it now provides the number of rows affected by its execution. This is significant as it allows for better understanding and tracking of data manipulations, making it easier to monitor and debug if required.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2265ce) 47.95% compared to head (9df32a2) 47.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20056      +/-   ##
==========================================
- Coverage   47.95%   47.95%   -0.01%     
==========================================
  Files         445      445              
  Lines       43887    43886       -1     
==========================================
- Hits        21045    21044       -1     
  Misses      22842    22842              
Files Coverage Δ
framework/db/QueryBuilder.php 91.25% <100.00%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark requested review from a team October 27, 2023 18:52
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 please add a line for CHANGELOG. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants