Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when fixture not found rather than ignoring. #20047

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

borgou
Copy link

@borgou borgou commented Oct 26, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️
Fixed issues when provided fixture not found(wrong namespace or use namespace like app/tests/unit/fixture, etc), there will be no warning.

@what-the-diff
Copy link

what-the-diff bot commented Oct 26, 2023

PR Summary

  • Enhanced Error Handling for Missing Fixtures
    The new changes provide feedback when the system is unable to find the specified 'fixtures' or test data. The system will now throw a clear error message if you try to find fixtures in a namespace, or a specified area of the software, where none exist. This will aid in quicker error identification and resolution.

@samdark samdark requested review from a team October 26, 2023 16:11
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (af1858c) 48.00% compared to head (c155fc8) 48.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20047      +/-   ##
==========================================
- Coverage   48.00%   48.00%   -0.01%     
==========================================
  Files         445      445              
  Lines       43887    43888       +1     
==========================================
  Hits        21069    21069              
- Misses      22818    22819       +1     
Files Coverage Δ
...ramework/console/controllers/FixtureController.php 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thanks

Co-authored-by: Bizley <pawel.bizley@gmail.com>
@bizley
Copy link
Member

bizley commented Oct 27, 2023

Please add a changelog line, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants