-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw exception when fixture not found rather than ignoring. #20047
Open
borgou
wants to merge
4
commits into
yiisoft:master
Choose a base branch
from
borgou:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borgou
commented
Oct 26, 2023
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ✔️ |
Fixed issues | when provided fixture not found(wrong namespace or use namespace like app/tests/unit/fixture, etc), there will be no warning. |
PR Summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #20047 +/- ##
==========================================
- Coverage 48.00% 48.00% -0.01%
==========================================
Files 445 445
Lines 43887 43888 +1
==========================================
Hits 21069 21069
- Misses 22818 22819 +1
☔ View full report in Codecov by Sentry. |
mtangoo
reviewed
Oct 26, 2023
bizley
reviewed
Oct 26, 2023
thanks Co-authored-by: Bizley <pawel.bizley@gmail.com>
Please add a changelog line, thanks. |
bizley
approved these changes
Oct 28, 2023
mtangoo
approved these changes
Oct 28, 2023
Arhell
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.