Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gridview or Listview 'maxButtonCount' attribute is not working wh… #19905

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

msobin
Copy link

@msobin msobin commented Jul 20, 2023

…en it's assign with 2 #19655

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues

@what-the-diff
Copy link

what-the-diff bot commented Jul 20, 2023

PR Summary

  • Bug Fix for Gridview and Listview Functionality
    The system had been experiencing an issue with the 'maxButtonCount' setting in Gridview and Listview operations. Specifically, it was failing to work as expected when set to a limit of 2. This concern has now been addressed and resolved, ensuring the expected functionality and usability of Gridview and Listview with regards to 'maxButtonCount'. This will definitely enhance the user experience and system performance.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (c8c0ea9) 48.89% compared to head (598a045) 48.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19905   +/-   ##
=======================================
  Coverage   48.89%   48.89%           
=======================================
  Files         445      445           
  Lines       42786    42787    +1     
=======================================
+ Hits        20919    20920    +1     
  Misses      21867    21867           
Impacted Files Coverage Δ
framework/widgets/LinkPager.php 62.06% <66.66%> (+0.44%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samdark samdark requested review from a team July 24, 2023 07:04
@terabytesoftw
Copy link
Member

You could add a unit test, to verify the case.

Thks.

@terabytesoftw terabytesoftw added the pr:request for unit tests Unit tests are needed. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:request for unit tests Unit tests are needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants