DateValidator add support for time values

[nkovacs]

DateValidator sets the time part to 00:00:00 when inserting the timestamp into timestampAttribute, because here the $timetype argument is set to IntlDateFormatter::None.
It doesn't help if you use Yii::$app->formatter->datetimeFormat as a format, because both Yii::$app->formatter->datetimeFormat and Yii::$app->formatter->dateFormat are "medium", so DateValidator doesn't know if you want to keep the time or not.

The other problem is that even though it cuts off the time part, it still accepts input that contains a time part.

[cebe]

DateValidator is not designed to work with time values currently.

[nkovacs]

I did some more testing. It works fine if you specify a format in php syntax.
If you use the ICU syntax and specify a time component, it won't cut off the time. But if the format does not contain a time component, it will still accept values that contain a time.

So as a workaround, you can either use IntlDateFormatter::getPattern with an appropriately constructed formatter to fix the first bug, or \yii\helpers\FormatConverter::convertDateIcuToPhp(Yii::$app->formatter->datetimeFormat, 'datetime')/\yii\helpers\FormatConverter::convertDateIcuToPhp(Yii::$app->formatter->dateFormat, 'date') to fix both, but the latter can't convert some special formats.

[cebe]

But if the format does not contain a time component, it will still accept values that contain a time.

this should now be fixed by #6553

[nkovacs]

I made an extension that fixes this: https://github.com/nkovacs/yii2-datetimepicker/blob/master/DateTimeValidator.php

Of course there would be no need to convert the short format to a full pattern if implemented in Yii's validator, but I had to do it so I wouldn't have to reimplement all the code in it.

[cebe]

should be fixed by #5053 (d60445c)

[cebe]

hm okay, not really.