Switching to PSR-2

[samdark]

See #2743, #9

[Ragazzo]

i am against spaces, in netbeans their usage is painful, also i dont think that switching PSR styles here and there is good, we should be strict in usage one of them and not jumping from one to another.

[nineinchnick]

Should we vote, I'm for it. I'm not bringing any arguments up, referred issues are enough.

[subdee]

I personally was hoping that Yii2 would conform to all the PSR standards, was disappointed to see that it doesn't. There's nothing wrong with conforming with a standard that's agreed upon.

Thus, I vote for PSR-2.

[digitalkaoz]

definitly for psrX...working with different coding styles in one project is a pain in the ass...iteroperability ftw, thats why mostly every php library switched to it, it simply makes code formatting a no-brainer in the php world...

personal preferences should stand back on this one, every ide can handle it properly.

[Ragazzo]

@digitalkaoz can you show me how faster you will be by browsing code with vim and PSR-2 spaces, or in netbeans IDE? So you are proposing that each programmer should be some piano master to remember all switch-combinations and use them? I also dont like arguments splitting in method signature, it only makes code unreadable.

[digitalkaoz]

so you rating "browsing code without shortcuts" higher than "common readability across different libraries"? vim: alt+shift+arrays, phpstorm alt+arrows ;)

its just not a matter of personal preferences, its a matter of a common sense, correct formatting is done by some tools or your ide itself

[Ragazzo]

yes, i rate usability higher than some ability with 3rd party libs, also you can see that there a lot of such decisions and PR in Yii2 where usability is higher then some other PSR. And you proposing to use 3-4 buttons for simple browsing? I dont like it, also remember that you can simply push some other button and consequences can be awful. How long you were using Yii? It looks like you just came and want to do everything right.

[joseph-kuruvilla]

Vote for PSR-2

[digitalkaoz]

yes i came by from a psrX world, where this discussion ended a few years ago in favor of a common sense ;)

[Ragazzo]

so, @digitalkaoz you was not using Yii and just forcing idea of spaces here, right? Do you understand that there are a lot of Yii1 and Yii2 (already) projects that use tabs, and a lot of Yii developers that already use and prefere to use tabs, and now you are just suggesting them to forget everything and support a lot of projects with new formatting?
I dont think that it is good. However as you can see Yii2 has some things from PSR-2, the only thing Yii does not have is spaces, well this is for historical reasons. So i think we should first listen for developers that were using Yii for some long time, and not switching right now. Note that with IDE you will have some problem by supporting old and new Yii projects with tabs and spaces, you will need to make IDE remember 2-3 desktop settings and switch between them each time.
The thing here is that you should adopt fw style, because you use it, and not suggeting to build everything from the ground.

[subdee]

Noone is forcing anyone to do anything. Many members of great PHP projects have already accepted a standard as a way to have interoperability. It is nice to have a community that agrees on some standards that would make developer's lives easier.

The argument about Yii1 is completely irrelevant. Whoever has started a project in Yii2 should've known about the risks of starting a project with a framework that is in Alpha still. Also, suggesting that just because someone hasn't used Yii since day one, doesn't have a say in this, gives a very bad image about the Yii community in general.

[digitalkaoz]

yes i am dont prejudiced against yii, but not using a common sense in the php world just sounds insane to me. its like being stuck in old paradigms

[Ragazzo]

@digitalkaoz so you telling me that all developers switched to spaces and none use tabs? really? what common sence are you talking about? Afaik there always will be 2 points: tabs vs spaces. And since you are not using Yii and dont know its workflow you are trying to force here PSR-2. That is not good. Well as i said, i am against it, but not for me to decide ofcourse, but all this last Yii2 changes just guide fw to some madness.

[schmunk42]

+1 for switching to PSR-2 ...

@Ragazzo What's the big deal about switching to spaces for a project once? Just run a formatter.
It is really annoying, that Yii 2 is practically the only project in your vendor folder which uses tabs rather than spaces.

There was a 50/50 chance for tabs vs. spaces in the standard, which is very widely accepted in the PHP world now. I didn't analyze ist, but I'd estimate 90% of extensions on packagist are using spaces.