Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: replace self PHPDoc parsers to phpdocumentor/reflection-docblock package #19053

Open
WinterSilence opened this issue Nov 30, 2021 · 8 comments

Comments

@WinterSilence
Copy link
Contributor

Vote to replace methods like as yii\console\Controller::parseDocCommentTags() to phpdocumentor/reflection-docblock.
Minuses:

  • add dependency

Pluses:

  • readable SOLID code
  • supports latest PHP features
@samdark
Copy link
Member

samdark commented Nov 30, 2021

What features aren't supported now that yii\console\Controller::parseDocCommentTags() is used for?

@samdark samdark added the pr:missing usecase It is not clear what is the use case for the pull request. label Nov 30, 2021
@yiisoft yiisoft deleted a comment from yii-bot Nov 30, 2021
@WinterSilence
Copy link
Contributor Author

WinterSilence commented Dec 2, 2021

@samdark I'm was talking not about concrete method.

What features aren't supported now that yii\console\Controller::parseDocCommentTags() is used for?

This dirty solution working wrong in some cases (Markdown description)

@samdark
Copy link
Member

samdark commented Dec 2, 2021

What cases are these?

@WinterSilence
Copy link
Contributor Author

@samdark

/**
 * Example:
 * ```
 * @fakeTag
 *    @fakeTag2
 * ```
 * @tag
 */

@samdark
Copy link
Member

samdark commented Dec 2, 2021

Are there real cases like that?

@WinterSilence
Copy link
Contributor Author

@samdark

Are there real cases like that?

this is no matter, if you don't want require vendor package we must extract this methods to class-helper

@samdark
Copy link
Member

samdark commented Dec 2, 2021

The abscence of use-case is important. That means that theoretically it is correct but practically noone needs that. And if so, why spend time on it instead of whats is really needed?

@samdark samdark added type:bug Bug severity:minor and removed pr:missing usecase It is not clear what is the use case for the pull request. labels Dec 2, 2021
@WinterSilence
Copy link
Contributor Author

@samdark to replace current methods to phpdocumentor/reflection-docblock need less than 30 min and I'm have time to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants