composer.json is invalid and package not available on packagist

[schmunk42]

Title says it all :)

PS: This package should also be moved to the core and yii2-dev.

[cebe]

created the package and updated composer.json

this package is not a yii extension so it should not be added to yii2-dev.

[schmunk42]

I thought it would make sense, because if you develop Yii 2 you want this package to check your code before you commit.

[cebe]

every package included in yii2-dev repo is considered a yii extension for composer package type so we should only put extensions in there.

[schmunk42]

OK, I just thought yii2-dev was short for development. Is there any other use case why you would install yii2-dev besides development?

If you have the package, you can easily check the style with

./vendor/bin/phpcs \
  --extensions=php \
  --standard=vendor/yiisoft/yii2-coding-standards/Yii2/ \
  ./vendor/schmunk42/packaii

edit PS: it such a minimal overhead, with a huge gain.

[cebe]

I think it is better to add the code style as dependency yourself if you need it. We are trying to keep unnecessary dependencies out of the packages to minimize download time. we could add it as a suggested package so people know about it.

[schmunk42]

Yes, as a suggest would be nice.

Von meinem iPhone gesendet

Am 07.02.2014 um 14:54 schrieb Carsten Brandt notifications@github.com:

I think it is better to add the code style as dependency yourself if you need it. We are trying to keep unnecessary dependencies out of the packages to minimize download time. we could add it as a suggested package so people know about it.

—
Reply to this email directly or view it on GitHub.