Removed Swiftmailer dependency #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luke-
commented
Jun 8, 2022
luke-
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes |
| Fixed issues | Codeception/module-yii2#64 |
luke-
changed the title
|
Can this be merged? |
|
I guess so. Please confirm, @samdark |
|
You've replaced it with a new hidden dependency though. Can't we just have a trivial value object implementation of the message interface and use that? |
Whilst much better, surely just removing swiftmailer is a step forward? |
|
Ok, yes it is still a hidden dependency. This is about removing the deprecated SwiftMailer dependency for the tests only. |
luke-
changed the title
|
Perhaps a new PR for the improved implementation? Seems like 2 seperate (but linked) issues? |
|
Can this be merged @samdark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.