Add rector [batch]

.github/workflows/rector.yml

@@ -0,0 +1,21 @@
+on:
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'infection.json.dist'
+      - 'psalm.xml'
+
+name: rector
+
+jobs:
+  rector:
+    uses: yiisoft/actions/.github/workflows/rector.yml@master
+    with:
+      os: >-
+        ['ubuntu-latest']
+      php: >-
+        ['8.0']

composer.json

@@ -36,6 +36,7 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5",
+        "rector/rector": "^0.14.3",
         "roave/infection-static-analysis-plugin": "^1.20",
         "spatie/phpunit-watcher": "^1.23",
         "vimeo/psalm": "^4.23",

rector.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
+use Rector\Config\RectorConfig;
+use Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector;
+use Rector\Set\ValueObject\LevelSetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->paths([
+        __DIR__ . '/src',
+        __DIR__ . '/tests',
+    ]);
+
+    // register a single rule
+    $rectorConfig->rule(InlineConstructorDefaultToPropertyRector::class);
+
+    // define sets of rules
+    $rectorConfig->sets([
+        LevelSetList::UP_TO_PHP_80,
+    ]);
+
+    $rectorConfig->skip([
+        ClosureToArrowFunctionRector::class,
+    ]);
+};

src/ApplicationRunner.php

@@ -22,9 +22,6 @@
  */
 abstract class ApplicationRunner implements RunnerInterface
 {
-    protected bool $debug;
-    protected string $rootPath;
-    protected ?string $environment;
     protected ?ConfigInterface $config = null;
     protected ?ContainerInterface $container = null;
     protected ?string $bootstrapGroup = null;
@@ -35,11 +32,8 @@ abstract class ApplicationRunner implements RunnerInterface
      * @param bool $debug Whether the debug mode is enabled.
      * @param string|null $environment The environment name.
      */
-    public function __construct(string $rootPath, bool $debug, ?string $environment)
+    public function __construct(protected string $rootPath, protected bool $debug, protected ?string $environment)
     {
-        $this->rootPath = $rootPath;
-        $this->debug = $debug;
-        $this->environment = $environment;
     }
 
     abstract public function run(): void;
@@ -48,8 +42,6 @@ abstract public function run(): void;
      * Returns a new instance with the specified bootstrap configuration group name.
      *
      * @param string $bootstrapGroup The bootstrap configuration group name.
-     *
-     * @return static
      */
     public function withBootstrap(string $bootstrapGroup): static
     {
@@ -60,8 +52,6 @@ public function withBootstrap(string $bootstrapGroup): static
 
     /**
      * Returns a new instance with bootstrapping disabled.
-     *
-     * @return static
      */
     public function withoutBootstrap(): static
     {
@@ -76,8 +66,6 @@ public function withoutBootstrap(): static
      * Note: The configuration of events is checked in debug mode only.
      *
      * @param string $eventsGroup Name of event configuration group to check.
-     *
-     * @return static
      */
     public function withCheckingEvents(string $eventsGroup): static
     {
@@ -88,8 +76,6 @@ public function withCheckingEvents(string $eventsGroup): static
 
     /**
      * Returns a new instance with disabled event configuration check.
-     *
-     * @return static
      */
     public function withoutCheckingEvents(): static
     {
@@ -102,8 +88,6 @@ public function withoutCheckingEvents(): static
      * Returns a new instance with the specified config instance {@see ConfigInterface}.
      *
      * @param ConfigInterface $config The config instance.
-     *
-     * @return static
      */
     public function withConfig(ConfigInterface $config): static
     {
@@ -116,8 +100,6 @@ public function withConfig(ConfigInterface $config): static
      * Returns a new instance with the specified container instance {@see ContainerInterface}.
      *
      * @param ContainerInterface $container The container instance.
-     *
-     * @return static
      */
     public function withContainer(ContainerInterface $container): static
     {

src/BootstrapRunner.php

@@ -16,13 +16,8 @@
  */
 final class BootstrapRunner implements RunnerInterface
 {
-    private ContainerInterface $container;
-    private array $bootstrapList;
-
-    public function __construct(ContainerInterface $container, array $bootstrapList = [])
+    public function __construct(private ContainerInterface $container, private array $bootstrapList = [])
     {
-        $this->container = $container;
-        $this->bootstrapList = $bootstrapList;
     }
 
     /**