Skip to content

Bump PHP to 8.1-8.4 + Enable BC checker#44

Merged
vjik merged 12 commits intomasterfrom
php81-84
Sep 22, 2025
Merged

Bump PHP to 8.1-8.4 + Enable BC checker#44
vjik merged 12 commits intomasterfrom
php81-84

Conversation

@vjik
Copy link
Member

@vjik vjik commented Sep 21, 2025

Q A
Is bugfix?
New feature?
Breaks BC?

@codecov
Copy link

codecov bot commented Sep 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.40%. Comparing base (e0c83d1) to head (bbeb8a3).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #44      +/-   ##
============================================
+ Coverage     91.95%   95.40%   +3.44%     
  Complexity       34       34              
============================================
  Files             3        3              
  Lines            87       87              
============================================
+ Hits             80       83       +3     
+ Misses            7        4       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +28 to +33
uses: yiisoft/actions/.github/workflows/bc.yml@master
with:
os: >-
['ubuntu-latest']
php: >-
['8.4']

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 5 months ago

To fix the problem, you should add a permissions block that explicitly limits the permissions available to the workflow. The best approach is to add this block at the workflow (top) level unless you know the job requires more elevated permissions than read-only. Since the job appears to merely check backward compatibility via a reusable workflow and likely does not need to write to the repository or create/update pull requests, a minimal contents: read permission is the least privileged and safest starting point. You should insert the following block near the top of the file, immediately after the name: property (line 25), so it applies to all jobs in the workflow:

permissions:
  contents: read

No additional methods, definitions, or library installations are necessary—just this single insertion.

Suggested changeset 1
.github/workflows/bc.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/bc.yml b/.github/workflows/bc.yml
--- a/.github/workflows/bc.yml
+++ b/.github/workflows/bc.yml
@@ -22,6 +22,8 @@
       - 'psalm.xml'
 
 name: backwards compatibility
+permissions:
+  contents: read
 
 jobs:
   roave_bc_check:
EOF
@@ -22,6 +22,8 @@
- 'psalm.xml'

name: backwards compatibility
permissions:
contents: read

jobs:
roave_bc_check:
Copilot is powered by AI and may make mistakes. Always verify output.
@vjik vjik requested a review from a team September 21, 2025 10:08
@vjik vjik added the status:code review The pull request needs review. label Sep 21, 2025
@vjik vjik merged commit 1bd8c4a into master Sep 22, 2025
20 checks passed
@vjik vjik deleted the php81-84 branch September 22, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants